fix(cli): reduce spinner flickering under patch_stdout#91
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Feb 27, 2026
Merged
fix(cli): reduce spinner flickering under patch_stdout#91teknium1 merged 1 commit intoNousResearch:mainfrom
teknium1 merged 1 commit intoNousResearch:mainfrom
Conversation
KawaiiSpinner used a two-phase clear+redraw approach: first write \r + spaces to blank the line, then \r + new frame. When running inside prompt_toolkit's patch_stdout proxy, each phase could trigger a separate repaint, causing visible flickering every 120ms. Replace with a single \r\033[K (carriage return + ANSI erase-to-EOL) write so the line is cleared and redrawn atomically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KawaiiSpinner._animate()used a two-phase approach to update spinner frames: first\r+ spaces to blank the line, then\r+ new content (agent/display.py:185)patch_stdoutproxy, each write can trigger a separate UI repaint, so the blank-then-redraw cycle causes visible flickering every 120ms\r\033[K(carriage return + ANSI erase-to-end-of-line) in a single write so the clear and redraw happen atomicallyReproduction