Skip to content

Support linkedin url for extracting information#44

Open
umitdincel wants to merge 5 commits intoOmkarPathak:masterfrom
umitdincel:master
Open

Support linkedin url for extracting information#44
umitdincel wants to merge 5 commits intoOmkarPathak:masterfrom
umitdincel:master

Conversation

@umitdincel
Copy link
Copy Markdown

@umitdincel umitdincel commented Dec 18, 2020

It may be useful to add linkedin url to extracting information

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2020

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@OmkarPathak
Copy link
Copy Markdown
Owner

@umitdincel it would be great if you add tests for this

@umitdincel
Copy link
Copy Markdown
Author

@OmkarPathak Added but it doesn't match your linkedin caption so is it possible to update it as full link?

@OmkarPathak
Copy link
Copy Markdown
Owner

@umitdincel it seems you have not tested the test that you wrote, go through the logs here: https://travis-ci.com/github/OmkarPathak/pyresparser/builds/211156947

@umitdincel
Copy link
Copy Markdown
Author

The build passed but the coverage looks like a little bit reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants