This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Hidelist hotfix#438
Merged
Merged
Conversation
#222 was a good attempt, but now that we have pages full of kettle bell listings, this hidelist approach results in pages full of empty or single listings. Per: >The only awkwardness of this implementation is that on a page with flagged listings, the grid won't be completely filled up. For example: So until we convert fully to address-based ids on listings, we stick with the old hidelist technicque of using Listing Indexes. (aka listingId)
Contributor
Author
|
In a separate PR I'll integrate these changes into master for future releases. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pull request? Read our guide to contributing
Checklist:
Description:
Hotfix which re-adds commits from #231 which were inadvertently removed. Allows us to hide listings by index rather than address, which allows us to paginate properly with the removed items, with no awkward whitespace on any pages.
I have already updated the
hide_listbranch to hide the latest blocked listings by index. So whenever this is merged/deployed the blocked listings will not reappear.