Typing for permuta/perm.py - #118
Merged
Merged
Conversation
Member
|
This looks promising, I added mypy to the test suite so that the typing is checked. |
enadeau
approved these changes
Jul 2, 2020
enadeau
left a comment
enadeau
left a comment
Member
There was a problem hiding this comment.
This is mostly good to go I think. I left a few comments that you should look at
|
|
||
| @classmethod | ||
| def to_standard(cls, iterable): | ||
| def to_standard(cls, iterable: Iterable) -> "Perm": |
Collaborator
Author
There was a problem hiding this comment.
I think this is used from all sort of iterables. The example in the docstring even has one with a string.
Member
There was a problem hiding this comment.
Seems reasonable even if in practice we only ever use int
| return self[value] | ||
|
|
||
| def __add__(self, other): | ||
| def __add__(self, other) -> "Perm": |
Member
There was a problem hiding this comment.
I think it's more pythonic to check the type of other and return NotImplemented when the class of the object is not a Perm
christianbean
added a commit
that referenced
this pull request
Jul 20, 2020
* add insenc and lexmin options to permtools (#116) * Typing for permuta/perm.py (#118) * typing, refactoring and naming perm.py * minor updates * add mypy to test suite * rem typechecking, prune comments, refactor perm.py * mypy fix permutils * mypy fix enum-strat * mypy fix _perm_set * mypy sympy * permset mypy fix * interfaces mypy fix * flake8 fix in interfaces * potential 36 fix * 3.6 issues solved * resolve issues * fix issues 2.0 Co-authored-by: Émile Nadeau <nadeau.emile@gmail.com> * Refactor (#120) * add sympy as dependency * more perm.py refactor + some tests * tests + refactor + reimplementing block method * more permpy tests and refactor, almost done * sympy top * . * removed Rotatable, Shiftable, Flippable abc * meshpatt refactor * remove comment * fix newl in docstr * doctest fixes * more fixes * fix isort issue * forgot -> type of inf iterator * fix issues * tmp solutions to sympy removal * Bivincular (#122) * rem cov badge * dihedral group * union find tests * misc cleared * tests updated * pre-move push * restructure * testing for bivpatt * added missing types * doctest fix * more_doctest_fixes * fix flake issues * Refactor permutils * permutils finite+sym refactor * poly refactor * poly deque for performance * utils refactoring done * issues and p_utils to putils * [requires.io] dependency update (#121) Co-authored-by: requires.io <support@requires.io> * SVG for patterns + HTML rendering (#125) * perm2svg * mesh svg * svg open in tab * openhtml cleanup * removal of file * Bisc perm properties refactor + tests (#127) * include bisc jsons in pypi package * .show in patts * bisc perm prop refactoring * forgot pylint in travis * missing comma in pylintrc * remove win from deployment * enumeration_strategies typing + removing permuta/descriptors (#129) * typing for enum_strat * removed readme.d + docs * forgot a few types in bisc-perm-prop * basis to permsets * basis * mp gen moved to mp * remove unused classvar * bivpatt random made uniform * doc fix * forgot len in rand * flake issue * and more fixes... * [requires.io] dependency update (#128) Co-authored-by: requires.io <support@requires.io> * permsets simplified (#130) * cache clear function in perm * minor cleanup in enumstrat * remove .vscode * .vscode to gitignore * basis refactor * perm_set simplified * comments + enum test * readme + comments + tests * cache fix + cache test * cache tests * fix assertion in Av * reduce memory of cache * reduce loop of auto cache clearing * issue fixing * identical types fix * cli typing (#132) * cli typing * typos + avoid iteration in cnt * poly to cli * , -> _ * version 2.0.0 * PEP 561 compatible Co-authored-by: Jón Steinn Elíasson <jonsteinn@gmail.com> Co-authored-by: Émile Nadeau <nadeau.emile@gmail.com> Co-authored-by: requires.io <support@requires.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing. Naming standardized for perm length and indices and elements in perms. Some refactoring. In
permuta/perm.py.