Conversation
The Azure pipelines configure with PCL_DISABLE_GPU_TESTS=ON because their agents have no GPU. This adds a GitHub Actions job that builds only the modules the gpu_octree tests need and runs them on a simulated NVIDIA T4. The performance test is left out: the simulator has no timing model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure pipelines build the GPU modules but configure with
PCL_DISABLE_GPU_TESTS=ON, because their agents have no GPU, so thegpu_octreetests never run in CI. This adds a GitHub Actions job that runs them on a simulated NVIDIA T4.How: PantheonSim, via
pantheongpu/setup-pantheonsim, installs the CUDA toolkit and simulates the GPU on the runner's CPU. The kernels run from their PTX (CUDA_ARCH_BIN=75embeds it), so the results are real. There is no timing model, so this checks correctness, not performance.Changes: one new workflow,
.github/workflows/gpu-tests.yml, on a plainubuntu-24.04runner:CUDA_ARCH_BIN=75and the shared CUDA runtime, since the simulator stands in forlibcudart;gpu_octree_performanceis left out: it is a timing benchmark, and on a simulated GPU it runs for over 50 minutes. The workflow only runs when the GPU octree code, its dependencies, the CMake files or the workflow itself change. The Azure pipelines are unchanged.What it can touch: the action is pinned by commit (v0.1.1), not by a tag, and it pins the simulator it builds by commit too, so nothing in the job changes until you move the pin. The workflow's token is read-only (
permissions: contents: read), and the action uses no token or secrets; it installs packages only from Ubuntu's and NVIDIA's repositories. The job isn't a required check, so a red run never blocks a merge unless you decide it should.What it gives, from a run on my fork:
gpu_octree_approx_nearest,bfrs,host_radius,knn_searchandradius_searchall pass, in about 3 minutes.Would it have caught past bugs? I undid two earlier fixes on current master and ran the same job (run):
volatileshared memory replaced by__shflinradius_search.cu): with the fix undone,batchRadiusSearchfails, in the search with a different radius per query, which is the case Inaccurate results with gpu octree search example #3583 reported.approxNearesSearch): with the fix undone, the test fails with the same two values reported from a real GPU, 0.0300000142 against 0.0300000124.Disclosure: I maintain PantheonSim. If the job is ever flaky or wrong, please open an issue at pantheongpu/pantheonsim and I'll fix it on our side.
🤖 Generated with Claude Code