-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix wildcard globbing in root of device paths #19442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wildcard globbing in root of device paths #19442
Conversation
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed for previous issues I've seen in globbing
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@SteveL-MSFT So the bugs you found are out of scope of the changes in this PR? |
@daxian-dbw the bugs were not due to this PR and should be addressed separately |
🎉 Handy links: |
PR Summary
Fixes scenarios like:
Get-ChildItem -Path '\\.\C:\*'
so it properly handles wildcards at the root.The code would find the parent of the wildcard (in this case
\\.\C:\
) but it would leave out the trailing separator (so it would end up like this:\\.\C:
) which is not valid for device path roots.This PR adds a check for root device paths and adds back the missing backslash if needed.
PR Context
Fixes #19439
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).