Rafa suggestions - #1969
Closed
garciadias wants to merge 14 commits into
Closed
Conversation
for more information, see https://pre-commit.ci
DCO Remediation Commit for christofhenkel <christof.henkel@campus.lmu.de> I, christofhenkel <christof.henkel@campus.lmu.de>, hereby add my Signed-off-by to this commit: 1db03fd I, christofhenkel <christof.henkel@campus.lmu.de>, hereby add my Signed-off-by to this commit: 2ffe23d I, christofhenkel <christof.henkel@campus.lmu.de>, hereby add my Signed-off-by to this commit: df958e7 Signed-off-by: christofhenkel <christof.henkel@campus.lmu.de> Signed-off-by: ChristofHenkel <christof.henkel@campus.lmu.de>
Signed-off-by: ChristofHenkel <henkel.christof@googlemail.com>
Signed-off-by: ChristofHenkel <christof.henkel@campus.lmu.de>
Signed-off-by: ChristofHenkel <henkel.christof@googlemail.com>
Signed-off-by: ChristofHenkel <christof.henkel@campus.lmu.de>
for more information, see https://pre-commit.ci
Signed-off-by: R. Garcia-Dias <rafaelagd@gmail.com>
for more information, see https://pre-commit.ci
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1947
Description
Hi @ChristofHenkel, I found some difficulties trying to run the instructions in your README file.
Here are some proposed changes to make it more straightforward and replicable.
Take a look and see if you want to change anything.
Many thanks,
Rafael