Dispose Rooster editor initialized after unmount - #536
Open
squarepots wants to merge 1 commit into
Open
squarepots wants to merge 1 commit into
squarepots wants to merge 1 commit into
Conversation
squarepots
force-pushed
the
fix/rooster-editor-unmount-dispose
branch
2 times, most recently
from
September 7, 2026 10:12
25890ba to
2b55f4e
Compare
squarepots
force-pushed
the
fix/rooster-editor-unmount-dispose
branch
from
September 7, 2026 15:13
2b55f4e to
2514cdd
Compare
mmso
force-pushed
the
main
branch
10 times, most recently
from
September 11, 2026 16:16
5eb5e79 to
28d81d1
Compare
mmso
force-pushed
the
main
branch
5 times, most recently
from
September 16, 2026 16:17
40a6c9b to
079f4b5
Compare
Author
|
Hi @nico3333fr, would you mind taking a look at this and the two related Rooster fixes, #538 and #540, when you have a chance? They’re all small, focused one-commit fixes with regression coverage. Thanks! |
mmso
force-pushed
the
main
branch
7 times, most recently
from
September 24, 2026 14:16
6cb99ea to
a0a8848
Compare
mmso
force-pushed
the
main
branch
7 times, most recently
from
October 1, 2026 20:16
57fccbd to
c51e81b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move asynchronous Rooster editor ownership into the effect instance that starts initialization. Each instance tracks its own cleanup state, disposes stale initialization before
onReady, and stores a live editor beforeonReadyso synchronous unmount still disposes it.Add focused lifecycle coverage for initialization completing after unmount, normal mounted cleanup, synchronous unmount from
onReady, and stale initialization under React Strict Mode.Verification
Fixes #535