Conversation
Previously PyAV only supported hardware decoding. Passing a hardware encoder (e.g. h264_vaapi) software frames failed at avcodec_open2 with EINVAL because no hw_device_ctx/hw_frames_ctx was ever set up. add_stream now accepts a hwaccel argument. For an encoder it attaches the device context, lazily builds the hw_frames_ctx in open() once width/height/pix_fmt are known, and uploads software frames to the device in _prepare_frames_for_encode. HWAccel setup now also accepts encoders, which advertise the HW_FRAMES_CTX method rather than HW_DEVICE_CTX. fixes #2156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously PyAV only supported hardware decoding. Passing a hardware encoder (e.g. h264_vaapi) software frames failed at avcodec_open2 with EINVAL because no hw_device_ctx/hw_frames_ctx was ever set up.
add_stream now accepts a hwaccel argument. For an encoder it attaches the device context, lazily builds the hw_frames_ctx in open() once width/height/pix_fmt are known, and uploads software frames to the device in _prepare_frames_for_encode. HWAccel setup now also accepts encoders, which advertise the HW_FRAMES_CTX method rather than HW_DEVICE_CTX.
fixes #2156