Skip to content

[MRG] Avoid changing precision in the backend - #572

Merged
rflamary merged 2 commits into
PythonOT:masterfrom
kachayev:fix-norm-precision
Nov 10, 2023
Merged

rflamary merged 2 commits into
PythonOT:masterfrom
kachayev:fix-norm-precision

Conversation

@kachayev

@kachayev kachayev commented Nov 10, 2023 •

Copy link
Copy Markdown
Collaborator

Types of changes

Fix previously added (see PR #507) precision change when computing norm on the PyTorch backend.

Motivation and context / Related issue

Precision change is not necessary, and fails on devices which don't have support for double precision.

Related discussion #570.

How has this been tested (if it applies)

n/a

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.
@codecov

codecov Bot commented Nov 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #572 (7dc0579) into master (a56e1b2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          67       67           
  Lines       14821    14821           
=======================================
  Hits        14304    14304           
  Misses        517      517           
@rflamary rflamary changed the title Avoid changing precision in the backend Nov 10, 2023
@rflamary
rflamary merged commit 91c67fb into PythonOT:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants