3.x: Fix Observable.flatMap with maxConcurrency hangs#6946
Merged
akarnokd merged 2 commits intoApr 4, 2020
Conversation
Member
Author
|
Yes. Added the test for it too anyway. |
Codecov Report
@@ Coverage Diff @@
## 3.x #6946 +/- ##
============================================
- Coverage 99.66% 99.60% -0.07%
+ Complexity 6665 6664 -1
============================================
Files 742 742
Lines 47220 47228 +8
Branches 6367 6369 +2
============================================
- Hits 47064 47043 -21
- Misses 46 60 +14
- Partials 110 125 +15 Continue to review full report at Codecov.
|
vanniktech
approved these changes
Apr 4, 2020
This was referenced Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued up scalar values were not counted as completed, thus the subsequent sources where not subscribed to to fill up the allowed concurrency level.
Fixes #6945