Skip to content

Add GitHub action to build with make oss (2nd)#4

Open
RichardCPoint wants to merge 3 commits into
mainfrom
make-oss-github-action
Open

Add GitHub action to build with make oss (2nd)#4
RichardCPoint wants to merge 3 commits into
mainfrom
make-oss-github-action

Conversation

@RichardCPoint

@RichardCPoint RichardCPoint commented Nov 24, 2025

Copy link
Copy Markdown
Owner
  • Installing fbthrift via Homebrew
  • Remove support for python3.12, to avoid the error:
    Traceback (most recent call last):
      File "/Users/rcollins/github/sl/3rd-party/3rd-attempt/sapling/eden/scm/setup.py", line 81, in <module>
        from distutils.ccompiler import new_compiler
    ModuleNotFoundError: No module named 'distutils'
    
  • Add dependency on anyhow, to avoid the error:
    error[E0433]: failed to resolve: use of unresolved module or unlinked crate `anyhow`
      --> saplingnative/bindings/modules/pyedenfsassertedstates/src/dummy_fb.rs:15:36
       |
    15 |     pub fn new(_path: &PathBuf) -> anyhow::Result<Self> {
       |                                    ^^^^^^ use of unresolved module or unlinked crate `anyhow`
       |
       = help: if you wanted to use a crate named `anyhow`, use `cargo add anyhow` to add it to your `Cargo.toml`
    
    error[E0433]: failed to resolve: use of unresolved module or unlinked crate `anyhow`
      --> saplingnative/bindings/modules/pyedenfsassertedstates/src/dummy_fb.rs:25:10
       |
    25 |     ) -> anyhow::Result<ContentLockGuard> {
       |          ^^^^^^ use of unresolved module or unlinked crate `anyhow`
       |
       = help: if you wanted to use a crate named `anyhow`, use `cargo add anyhow` to add it to your `Cargo.toml`
    
    For more information about this error, try `rustc --explain E0433`.
    error: could not compile `pyedenfsassertedstates` (lib) due to 2 previous errors
    
  • Setting THRIFT_INCLUDE_PATH to repo root to avoid the error:
    error: failed to run custom build command for `fb303_core v0.0.0 (https://github.com/facebook/fb303.git?branch=main#f8745c15)`
    
      --- stderr
    
      thread 'main' panicked at /Users/rcollins/.cargo/git/checkouts/fb303-bf38226a6f1fe012/f8745c1/fb303/thrift/rust/thrift_build.rs:27:10:
      Failed while running thrift compilation: Command 'Command {
          program: "/opt/homebrew/Cellar/fbthrift/2025.09.15.00/bin/thrift1",
          args: [
              "/opt/homebrew/Cellar/fbthrift/2025.09.15.00/bin/thrift1",
              "--gen",
              "mstch_rust:cratemap=/Users/rcollins/github/sl/3rd-party/3rd-attempt/sapling/eden/scm/build/cargo-target/release/build/fb303_core-9691648f7f394b1c/out/cratemap,types_crate=fb303_core__types,clients_crate=fb303_core__clients,deprecated_default_enum_min_i32,serde",
              "--out",
              "/Users/rcollins/github/sl/3rd-party/3rd-attempt/sapling/eden/scm/build/cargo-target/release/build/fb303_core-9691648f7f394b1c/out",
              "-I",
              ".",
              "fb303/thrift/fb303_core.thrift",
          ],
          cwd: Some(
              "../../..",
          ),
      }' failed! Stdout:
    
      Stderr:
      [ERROR:fb303/thrift/fb303_core.thrift:30] Could not find include file thrift/annotation/cpp.thrift  ```
    
@RichardCPoint RichardCPoint force-pushed the make-oss-github-action branch 11 times, most recently from d981b29 to 3195d32 Compare November 25, 2025 01:32
@rejc2

rejc2 commented Dec 3, 2025

Copy link
Copy Markdown

Here's a comment

@rejc2

rejc2 commented Dec 3, 2025

Copy link
Copy Markdown

Here's a comment @RichardCPoint

@rejc2

rejc2 commented Dec 3, 2025

Copy link
Copy Markdown

Another comment.

@RichardCPoint

Copy link
Copy Markdown
Owner Author

My own comment

@rejc2

rejc2 commented Dec 3, 2025

Copy link
Copy Markdown

My own comment
And back.

@rejc2

rejc2 commented Dec 3, 2025

Copy link
Copy Markdown

Yet another comment.

@RichardCPoint RichardCPoint force-pushed the make-oss-github-action branch from 3195d32 to 35755d8 Compare January 4, 2026 15:57
@RichardCPoint RichardCPoint force-pushed the make-oss-github-action branch from 35755d8 to fa0ce48 Compare January 5, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants