Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

fix(mobile): 修复移动端 UI 鼠标无法切换页面 - #1061

Merged
imsyy merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/fix/mobile-mouse
May 5, 2026
Merged

imsyy merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/fix/mobile-mouse

Conversation

@MoYingJi

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 30, 2026 16:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 旨在修复移动端全屏播放器底部分页指示器(圆点)在鼠标/指针交互下无法点击切换页面的问题,使分页圆点可响应点击并提升可点击命中区域。

Changes:

  • 为分页圆点启用 pointer-events 并设置 cursor: pointer,允许在分页容器 pointer-events: none 的前提下仍可点击圆点
  • 通过 ::after 伪元素扩大圆点的可点击热区,提升可用性

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the interaction area for pagination dots in the mobile player by implementing a pseudo-element to expand the hit target. A review comment identifies that the current horizontal offsets cause overlapping click areas between adjacent dots, leading to imprecise event triggering; it suggests reducing the offset to ensure a clean split at the center of the gap.

Comment on lines +557 to +564
&::after {
content: "";
position: absolute;
top: -16px;
bottom: -16px;
left: -8px;
right: -8px;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

使用 ::after 伪元素扩大点击区域是一个很好的做法,但目前的 left 和 right 偏移量(-8px)结合 gap: 8px 的设置,会导致相邻指示点的点击区域在间隙处完全重叠。由于后一个点在 DOM 顺序中靠后,点击两个点之间的间隙将始终触发后一个点的事件。这会导致用户点击靠近左侧点的间隙时却切换到了右侧页面,交互逻辑不够精确。建议将水平偏移量调整为 -4px,使点击区域在间隙中心衔接。

      &::after {
        content: "";
        position: absolute;
        top: -16px;
        bottom: -16px;
        left: -4px;
        right: -4px;
      }
@imsyy
imsyy merged commit fb2f172 into SPlayer-Dev:dev May 5, 2026
4 checks passed
@MoYingJi
MoYingJi deleted the pr/fix/mobile-mouse branch June 4, 2026 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants