Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

🔧 build: 优化原生模块构建 - #850

Merged
imsyy merged 4 commits into
SPlayer-Dev:devfrom
apoint123:build/optimize-native-build
Feb 9, 2026
Merged

imsyy merged 4 commits into
SPlayer-Dev:devfrom
apoint123:build/optimize-native-build

Conversation

@apoint123

Copy link
Copy Markdown
Member

在开发模式下使用 dev profile 以加快构建速度

同时配置了 eslint 和 prettier 排除了原生模块和 autoEslint 的自动生成文件以免全局格式化产生大量噪音

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @apoint123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过优化原生模块的构建过程和改进代码格式化工具的配置来提升开发体验。通过在开发模式下使用更快的构建配置,并精确地排除自动生成的文件,可以显著减少开发迭代时间并保持代码库的整洁。

Highlights

  • 构建优化: 在开发模式下,原生模块现在使用 build:debug 命令进行构建,该命令在 napi build 中移除了 --release 标志,以加快构建速度。
  • 格式化和 Linting 排除: ESLint 和 Prettier 配置已更新,以排除原生模块生成的 index.d.ts 文件以及 auto-eslint.mjs 文件,从而减少自动格式化和 Linting 过程中产生的噪音。
Changelog
  • .prettierignore
    • 添加了 native/**/index.d.ts 以忽略原生模块的类型定义文件。
    • 添加了 auto-eslint.mjs 以忽略自动生成的 ESLint 配置文件。
  • eslint.config.mjs
    • 调整了导入语句的顺序。
    • 在 ignores 数组中添加了 native/**/index.d.ts,以排除原生模块的类型定义文件。
  • native/external-media-integration/package.json
    • 为 scripts 添加了 build:debug 命令,使用 napi build --no-const-enum。
  • native/taskbar-lyric/package.json
    • 为 scripts 添加了 build:debug 命令,使用 napi build --no-const-enum。
  • native/tools/package.json
    • 为 scripts 添加了 build:debug 命令,使用 napi build --no-const-enum。
  • package.json
    • 修改了 dev 脚本,使其在调用 build:native 时传递 --dev 参数。
  • scripts/build-native.ts
    • 调整了导入语句的顺序。
    • 引入了 isDev 变量,根据是否传入 --dev 参数来决定使用 build:debug 或 build 命令来构建原生模块。
Activity
  • 此拉取请求自创建以来没有记录到任何评论或审查活动。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在通过在开发模式下使用 dev profile 来优化原生模块的构建速度,同时更新了 Prettier 和 ESLint 的忽略配置,以排除自动生成的文件。整体来看,这些改动是合理且有效的。我只发现了一个可以改进的地方:在 scripts/build-native.ts 中,构建各个原生模块的逻辑存在重复,可以通过重构来提高代码的可维护性。

Comment thread scripts/build-native.ts Outdated
@imsyy
imsyy merged commit b88f12d into SPlayer-Dev:dev Feb 9, 2026
@apoint123
apoint123 deleted the build/optimize-native-build branch February 9, 2026 03:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants