Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

修复因为开启私人漫游导致无法打开分享链接 - #898

Merged
apoint123 merged 1 commit into
devfrom
dev-cy
Feb 18, 2026
Merged

apoint123 merged 1 commit into
devfrom
dev-cy

Conversation

@kazukokawagawa

Copy link
Copy Markdown
Collaborator

No description provided.

@kazukokawagawa kazukokawagawa self-assigned this Feb 18, 2026
@kazukokawagawa
kazukokawagawa marked this pull request as ready for review February 18, 2026 08:25
Copilot AI review requested due to automatic review settings February 18, 2026 08:25
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求解决了当“私人漫游”模式(个人FM)处于活动状态时,共享音乐链接无法正确打开和播放的问题。它调整了播放逻辑,以正确处理从个人FM模式切换到播放特定歌曲的情况,即使该歌曲的ID与当前播放的歌曲相同。

Highlights

  • 个人漫游模式处理: 修复了在个人漫游模式下,通过分享链接播放歌曲时可能无法正确启动播放的问题,确保即使歌曲ID相同也能正确处理模式切换。
Changelog
  • src/core/player/PlayerController.ts
    • 调整了歌曲播放逻辑,以考虑个人漫游模式的状态。
Activity
  • 此拉取请求自创建以来没有记录到任何活动。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这次的修改解决了在私人漫游模式下无法打开分享链接的问题。通过在 addNextSong 方法中记录并使用之前的 personalFmMode 状态,你正确地处理了从私人漫游切换到普通播放列表的逻辑,避免了错误地跳过歌曲添加流程。

代码的修复逻辑是正确的。我只提了一个关于代码风格和一致性的小建议,可以让这部分逻辑更清晰。

总体来说,这是一个很好的修复!

Comment on lines +1076 to 1078
const wasPersonalFm = statusStore.personalFmMode;
// 关闭特殊模式
if (statusStore.personalFmMode) statusStore.personalFmMode = false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

为了代码的一致性,建议在这里使用已经声明的 wasPersonalFm 变量。这样可以避免重复访问 statusStore.personalFmMode 属性。

Suggested change
const wasPersonalFm = statusStore.personalFmMode;
// 关闭特殊模式
if (statusStore.personalFmMode) statusStore.personalFmMode = false;
const wasPersonalFm = statusStore.personalFmMode;
// 关闭特殊模式
if (wasPersonalFm) statusStore.personalFmMode = false;

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where share links fail to open properly when the personal FM mode is enabled. The problem occurs when a user clicks a share link while in personal FM mode and the shared song is already playing.

Changes:

  • Modified the addNextSong method to properly handle song playback when transitioning out of personal FM mode
@apoint123
apoint123 merged commit c148133 into dev Feb 18, 2026
10 checks passed
@apoint123
apoint123 deleted the dev-cy branch February 22, 2026 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants