Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

fix(package): 删除依赖项中的 tools 原生模块包 - #900

Merged
apoint123 merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/fix
Feb 19, 2026
Merged

apoint123 merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/fix

Conversation

@MoYingJi

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 13:14
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MoYingJi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过标准化 package.json 中本地依赖的路径分隔符来增强构建过程的健壮性。这一更改确保了 tools 模块在不同操作系统或构建环境中的正确解析,从而避免了潜在的构建失败或模块加载问题。

Highlights

  • 修复构建依赖路径: 将 package.json 中 tools 依赖的本地路径分隔符从反斜杠 \ 更新为正斜杠 /,以解决构建过程中可能出现的路径问题。
Changelog
  • package.json
    • 更新了 tools 依赖的本地路径,将 Windows 风格的反斜杠替换为跨平台的正斜杠。
Activity
  • 此拉取请求自创建以来没有记录到人工活动。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了 package.json 中 tools 依赖的路径分隔符问题。通过将 Windows 风格的反斜杠(\)修改为跨平台兼容的正斜杠(/),提升了构建脚本在不同操作系统上的兼容性。这个改动是正确的,并且遵循了在 package.json 中定义路径的最佳实践。代码审查没有发现问题。

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a cross-platform compatibility issue by correcting the path separator in the tools package dependency link from a Windows-specific backslash to a forward slash.

Changes:

  • Updated the tools dependency path from link:native\\tools to link:native/tools in package.json
@apoint123

Copy link
Copy Markdown
Member

其实这个包应该删掉的,因为目前 SPlayer 是手动复制并 require 原生模块,这样安装只有 import 的时候才会用到

现在不用 import 的原因是不好控制编译和安装,虽然 import 确实更符合人体工程学

> 其实这个包应该删掉的,因为目前 SPlayer 是手动复制并 require 原生模块,这样安装只有 import 的时候才会用到
>
> 现在不用 import 的原因是不好控制编译和安装,虽然 import 确实更符合人体工程学
@MoYingJi MoYingJi changed the title fix(build): 修复 tools 依赖路径分隔符问题 Feb 18, 2026
@apoint123
apoint123 merged commit d5b0b02 into SPlayer-Dev:dev Feb 19, 2026
@MoYingJi
MoYingJi deleted the pr/fix branch February 19, 2026 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants