Skip to content
This repository was archived by the owner on Jul 17, 2026. It is now read-only.

feat(FullPlayer): 评论页半屏显示 - #983

Merged
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/hc
Mar 9, 2026
Merged

imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/hc

Conversation

@MoYingJi

@MoYingJi MoYingJi commented Mar 7, 2026 •

Copy link
Copy Markdown
Collaborator
屏幕截图_20260308_233426
Copilot AI review requested due to automatic review settings March 7, 2026 15:11
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求引入了全屏播放器评论页的半屏显示功能。用户现在可以选择将评论显示在播放器的左侧半屏区域,而不是传统的全屏覆盖模式。这为用户提供了更灵活的界面布局选项,提升了全屏播放器的个性化体验。

Highlights

  • 新功能:评论页半屏显示: 添加了全屏播放器评论页半屏显示(左侧)的新设置选项,允许用户选择评论的显示方式。
  • 评论显示逻辑重构: 重构了 FullPlayer.vue 中评论的显示逻辑,以支持全屏和半屏两种模式,并引入了新的计算属性来管理显示状态。
  • CSS 类名更新: 将全屏评论显示时的 CSS 类名从 show-comment 更新为 fullscreen-comment,以更清晰地反映其功能。
Changelog
  • src/components/Modal/Setting/FullscreenPlayerManager.vue
    • 新增了“评论页半屏显示(左侧)”的设置项。
  • src/components/Player/FullPlayer.vue
    • 更新了播放器光标显示逻辑,以适应新的评论显示状态。
    • 修改了独立歌词的显示条件,使其与新的评论显示逻辑保持一致。
    • 调整了左侧内容区域的渲染逻辑,增加了半屏评论的显示插槽。
    • 重构了全屏评论的显示条件。
    • 定义了 showComment、commentHalfScreen、showFullScreenComment 和 showHalfScreenComment 等计算属性,用于精细控制评论的显示模式。
    • 更新了全屏封面显示条件。
    • 将 show-comment CSS 类名更改为 fullscreen-comment。
  • src/stores/setting.ts
    • 在 FullscreenPlayerElementKey 接口中添加了 commentHalfScreen 属性。
    • 为 commentHalfScreen 设置了默认值 false。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 实现了一个新功能,允许在全屏播放器中以半屏模式显示评论区。这是一个很好的增强。代码的改动主要在 FullPlayer.vue 组件中,重构了评论显示的逻辑,并增加了一个新的设置项。整体实现是合理的,但我发现一个小问题:当评论区以半屏模式显示时,鼠标指针会错误地隐藏,影响了用户与评论区的交互。我已经就此问题提出了具体的修改建议。

Comment thread src/components/Player/FullPlayer.vue Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 为全屏播放器(FullPlayer)的评论页增加“半屏显示(占左侧区域)”能力,并通过设置项控制评论展示方式,以便在看评论时仍保留右侧歌词/信息区域的布局。

Changes:

  • 在设置存储中新增 fullscreenPlayerElements.commentHalfScreen 开关及默认值。
  • FullPlayer 根据 commentHalfScreen 将评论渲染为“全屏覆盖”或“左侧半屏”两种模式。
  • 设置面板(FullscreenPlayerManager)新增“评论页半屏显示(左侧)”开关。

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/stores/setting.ts 新增全屏播放器元素配置项 commentHalfScreen 并初始化默认值
src/components/Player/FullPlayer.vue 重构评论显示逻辑,支持全屏/半屏两种评论布局
src/components/Modal/Setting/FullscreenPlayerManager.vue 设置面板增加半屏评论开关入口

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/components/Player/FullPlayer.vue Outdated
Comment thread src/components/Player/FullPlayer.vue Outdated
Comment thread src/components/Player/FullPlayer.vue Outdated
# Conflicts:
#	src/components/Player/FullPlayer.vue
@imsyy
imsyy merged commit eb1d809 into SPlayer-Dev:dev Mar 9, 2026
@MoYingJi
MoYingJi deleted the pr/hc branch March 11, 2026 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants