Fix: load materializations before run janitor#5723
Open
cnahed-kpler wants to merge 1 commit into
Open
Conversation
|
|
Collaborator
|
@cnahed-kpler could you take a look at resolving conflicts? |
Collaborator
|
I just kicked off the workflows. Once they all pass, I'll merge! |
Collaborator
|
@cnahed-kpler Can you add DCO checks? |
Collaborator
|
You can ignore those failed style ci tests, there was a bug from another merge, but the fix got merged. |
Collaborator
|
@cnahed-kpler Just following up |
Contributor
|
This PR should close this issue #5761 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure materializations are loaded before cleanup-related logic runs.
That matters because janitor/cleanup operations depend on materialization definitions already being available.
This occurs here: https://github.com/TobikoData/sqlmesh/blob/6e69ce6cfbceab8e7c5f43cdaa7ac7a5d9015cd6/sqlmesh/core/snapshot/evaluator.py#L2877