Fix: Fallback to DROP VIEW if DROP TABLE fails in DuckDB#5809
Draft
alessio-giuliano-pix4d wants to merge 1 commit into
Draft
Fix: Fallback to DROP VIEW if DROP TABLE fails in DuckDB#5809alessio-giuliano-pix4d wants to merge 1 commit into
alessio-giuliano-pix4d wants to merge 1 commit into
Conversation
Signed-off-by: Alessio Giuliano <alessio.giuliano@pix4d.com>
Collaborator
|
@alessio-giuliano-pix4d Can you add tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #5438
Description
DuckDB has trouble detecting the type of relations when interacting with Postgres through
duckdb-postgres: Views are treated like tables. (see linked issue for more detail)The proposed fix is simply to add a fallback to drop the relation with
DROP VIEWifDROP TABLEfails. The code is inspired from another PR attempting a fix: #5695.Test Plan
I tested this locally on a project that was impacted by issue #5438, and verified that the problem was indeed gone.
Note that since I don't know this codebase at all, I'm not 100% convinced about the robustness of this change.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO