Tags: Sathvik-Chowdary-Veerapaneni/fbthrift
Tags
Fix typo "occured" to "occurred" in error message string at... Summary: - Fix typo "occured" to "occurred" in error message string at analytics_libs/market/foundation/enrichment/logging.py describing exception handling. - Fix typo "sucess" to "success" in format string at scribe/scope_manager/CategoryTraceSamplingPublisher.cpp in the trace sampling run complete log message. - Fix typo "Wether" to "Whether" in flag description string at thrift/lib/cpp2/protocol/DebugProtocol.cpp for thrift_cpp2_debug_skip_list_indices. AI Review: - security: PASSED (1.00) — All three changes are purely cosmetic typo fixes in string literals (log messages and flag descriptions). No logic, control flow, or data handling is altered. No security implications. - quality: PASSED (0.95) — All three changes are straightforward typo fixes in string literals (log messages, format strings, and flag descriptions). No function signatures, return values, or logic are modified. The corrections are accurate: "occured" → "occurred", "sucess" → "success", "Wether" → "Whether". These changes cannot break any callers or dependent code since they only affect human-readable text content. - task_solution: PASSED (1.00) — All three typo fixes are correct, minimal, and carry zero risk of regression. Reviewed By: dtolnay Differential Revision: D96668510 fbshipit-source-id: e70a75aaae532a6952332f774d1ce860266569de
Replace __fbthrift_reflection_field_ids_in_serialization_order with `… …op::for_each_field_id_ascending` Summary: In the previous diff we added the ability to serialize by field id order without the sorted list in `__fbthrift_reflection_field_ids_in_serialization_order`. Note: we still need codegen to create `__fbthrift_serialize_in_field_id_order` when `thrift.SerializeInFieldIdOrder` annotation exists . We can't use `op::has_struct_annotation<...>()` since that would introduce circular dependency. (alternatively we can move `SerializeInFieldIdOrder` out of `thrift.thrift` to avoid circular dependency). Reviewed By: hchokshi Differential Revision: D94948755 fbshipit-source-id: 7ab228e24fd341ccbe3820ae993f40972e6a08aa
Add missing folly/container/small_vector.h include to AnyPatch.cpp Summary: D93787534 introduced the use of `folly::small_vector<const DynamicPatch*, 2>` in `AnyPatch.cpp` but did not include the required header `<folly/container/small_vector.h>`. This change adds the missing include to both `fbcode/thrift/lib/thrift/detail/AnyPatch.cpp` and `xplat/thrift/lib/thrift/detail/AnyPatch.cpp`, and updates the BUCK files to include the dependency `//folly/container:small_vector` in `cpp2_private_deps`. This resolves the 44 build failures in aps_models tests that were caused by the missing include. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=T257475193-00aff276-fdae-491b-8b1b-cb5856a4689c) Reviewed By: aristidisp Differential Revision: D94758121 fbshipit-source-id: 501f8ed9edb48f923ebc60101775a08ad9af16f6
Remove mstch_go_program Summary: TSIA Reviewed By: hchokshi Differential Revision: D93928487 fbshipit-source-id: 31d6926444b094aa2e7aa3c63f2b638ad7751710
Updating hashes Summary: GitHub commits: facebook/fb303@a36e139 facebook@0d9e7ac facebook/mvfst@982db07 facebook/proxygen@82e2ac1 facebook/wangle@bc7c7ec facebookexperimental/edencommon@31e4fbd facebookexperimental/rust-shed@aea9dce facebookincubator/fizz@2ba698d Reviewed By: bigfootjon fbshipit-source-id: d24a8ae6fade054ec1cd5c368327dfe445e47dc3
Fix test fixtures Reviewed By: prakashgayasen Differential Revision: D92623870 fbshipit-source-id: 7e5e3b34ab93e31942cbf4d93f0e626559fe0ce6
Updating hashes Summary: GitHub commits: facebook/buck2-prelude@e580cfb facebook/fb303@dfe13cf facebook@297524a facebook/mvfst@fe4f924 facebook/proxygen@fc876f4 facebook/wangle@f4dcd7f facebookexperimental/edencommon@c02d12c facebookexperimental/rust-shed@b1a06e2 facebookincubator/fizz@2538012 Reviewed By: sdwilsh fbshipit-source-id: 89b5d9340c19294321c3a1e2ca0a085fb71a21bc
Fix hack union conformance Summary: Strict unions have rolled out to >90% thrift files. Hack unions are now conformant by default and so these test cases can be removed from "noncoformant" list. Differential Revision: D91386093 fbshipit-source-id: b0c7f0b8e3061fd84918850220d770cd5ba7d604
Update GDA annotation 31/x Summary: Summary Project Rollout Plan https://docs.google.com/document/d/1RbQYyu7Ja9fGFavZrMsGTT0_Ntv4CUey0YH9mVf5HVc/edit?tab=t.0#heading=h.3ddwc12wbzsx Previously, GDA annotations were broadly applied to delegate pages, but subsequent review identified several false positives, cases where the annotation was not required. This change removes unnecessary GDA annotations from affected test classes and modules, ensuring that only the correct entities retain the annotation. This should reduce noise in privacy enforcement and improve the accuracy of our data governance labeling. Differential Revision: D90789459 fbshipit-source-id: 0b25d2d4cb1940bfb595b4d3677a24ebf0435ca2
apply Black 25.11.0 style in fbcode (72/92) Summary: Formats the covered files with pyfmt. paintitblack Reviewed By: itamaro Differential Revision: D90476322 fbshipit-source-id: e689aa40511799087010490a2ebe5260d41130c8
PreviousNext