Skip to content

fix(button): fix anchor hover + visited font color #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

fix(button): fix anchor hover + visited font color #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a88162
fix(button): fix anchor hover + visited font color
dancormier Feb 21, 2025
0b83a56
Merge branch 'develop' into dcormier/fix-btn-filled-visited-hover-fc
giamir Feb 24, 2025
99f4495
Merge branch 'develop' into dcormier/fix-btn-filled-visited-hover-fc
giamir Feb 24, 2025
967bce5
Add anchor-based buttons to docs
dancormier Feb 24, 2025
7fd1391
Merge branch 'develop' into dcormier/fix-btn-filled-visited-hover-fc
dancormier Feb 24, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions docs/_data/buttons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,61 @@
]
}
],
"anchor": [
{
"title": "Anchors",
"classes": [
{
"title": "Secondary, Clear"
},
{
"title": "Secondary, Outlined",
"class": "s-btn__outlined"
},
{
"title": "Secondary, Filled",
"class": "s-btn__filled"
},
{
"title": "Danger, Clear",
"class": "s-btn__danger"
},
{
"title": "Danger, Outlined",
"class": "s-btn__danger",
"class2": "s-btn__outlined"
},
{
"title": "Danger, Filled",
"class": "s-btn__danger",
"class2": "s-btn__filled"
},
{
"title": "Featured, Clear",
"class": "s-btn__featured"
},
{
"title": "Featured, Outlined",
"class": "s-btn__featured",
"class2": "s-btn__outlined"
},
{
"title": "Featured, Filled",
"class": "s-btn__featured",
"class2": "s-btn__filled"
},
{
"title": "Muted, Clear",
"class": "s-btn__muted"
},
{
"title": "Muted, Outlined",
"class": "s-btn__muted",
"class2": "s-btn__outlined"
}
]
}
],
"badges": [
{
"title": "Badge",
Expand Down
54 changes: 54 additions & 0 deletions docs/product/components/buttons.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,60 @@
</div>
</section>


<section class="stacks-section">
{% header "h2", "Anchors" %}
<p class="stacks-copy">Anchors can be rendered with the <code class="stacks-code">.s-btn</code> to adopt a button-like visual style for a link.</p>

<div class="stacks-preview">
{% highlight html %}
<a href="#" class="s-btn">Ask question</a>
{% endhighlight %}
<div class="stacks-preview--example">
<div class="overflow-x-auto">
<table class="wmn5 s-table s-table__bx-simple">
<thead>
<tr>
<th scope="col">Type</th>
<th scope="col" class="s-table--cell4">Class</th>
<th scope="col" class="ta-center">Default State</th>
<th scope="col" class="ta-center">Selected State</th>
<th scope="col" class="ta-center">Disabled State</th>
</tr>
</thead>
<tbody>
{% for btn in buttons.anchor %}
{% assign types = btn.classes %}
{% for class in types %}
<tr>
<th scope="row" class="va-middle">{{ class.title }}</th>
<td class="va-middle">
<div class="d-flex g4 fw-wrap">
<code class="flex--item stacks-code">.s-btn</code>
{% if class.class != nil %}
<code class="flex--item stacks-code">.{{ class.class }}</code>
{% endif %}
{% if class.class2 != nil %}
<code class="flex--item stacks-code">.{{ class.class2 }}</code>
{% endif %}
{% if btn.class != nil %}
<code class="flex--item stacks-code">.{{ btn.class }}</code>
{% endif %}
</div>
</td>
<td class="va-middle ta-center px4"><a href="#" class="ws-nowrap s-btn {{ class.class }} {% if class.class2 %}{{ class.class2 }}{% endif %}">Ask question</a></td>
<td class="va-middle ta-center px4"><a href="#" class="ws-nowrap s-btn {{ class.class }} {% if class.class2 %}{{ class.class2 }}{% endif %} is-selected" aria-pressed="true">Ask question</a></td>
<td class="va-middle ta-center px4"><a href="#" class="ws-nowrap s-btn {{ class.class }} {% if class.class2 %}{{ class.class2 }}{% endif %}" disabled>Ask question</a></td>
</tr>
{% endfor %}
{% endfor %}
</tbody>
</table>
</div>
</div>
</div>
</section>

<section class="stacks-section">
{% header "h2", "Loading" %}
<p class="stacks-copy">Any button can have a loading state applied by adding the <code class="stacks-code">.is-loading</code> state class.</p>
Expand Down
12 changes: 6 additions & 6 deletions lib/components/button/button.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,13 +441,13 @@
}

&:visited:not(:active):not(:focus) {
&.s-btn__filled {
background-color: var(--_bu-filled-bg);
border-color: var(--_bu-filled-bc);
color: var(--_bu-filled-fc);
}

&:not(.s-btn__outlined) {
&.s-btn__filled {
background-color: var(--_bu-filled-bg-hover);
border-color: var(--_bu-filled-bc-hover);
color: var(--_bu-filled-fc-hover);
}

background-color: var(--_bu-bg);
border-color: var(--_bu-bc);
color: var(--_bu-fc);
Expand Down