Skip to content

SSLParameters for WebSocketClient#1000

Merged
marci4 merged 4 commits into
TooTallNate:masterfrom
marci4:Issue997
Apr 23, 2020
Merged

SSLParameters for WebSocketClient#1000
marci4 merged 4 commits into
TooTallNate:masterfrom
marci4:Issue997

Conversation

@marci4

@marci4 marci4 commented Apr 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This feature enables the access to the SSLParameters and enables hostname validation by default

Related Issue

Fixes #997

Motivation and Context

Security (fixes missing hostname validation)

How Has This Been Tested?

Tests were created

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@marci4 marci4 requested a review from PhilipRoman April 19, 2020 15:23
@marci4 marci4 added this to the Release 1.5.0 milestone Apr 19, 2020
PhilipRoman
PhilipRoman reviewed Apr 20, 2020
View reviewed changes
Comment thread src/main/example/SSLClientExample.java Outdated
Comment thread src/main/java/org/java_websocket/client/WebSocketClient.java
Comment thread src/test/java/org/java_websocket/issues/Issue997Test.java Outdated
Comment thread src/test/java/org/java_websocket/issues/Issue997Test.java
@PhilipRoman PhilipRoman mentioned this pull request Apr 22, 2020
Merged
8 tasks
@marci4 marci4 merged commit cab3fda into TooTallNate:master Apr 23, 2020
@marci4 marci4 deleted the Issue997 branch April 23, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment