Skip to content

fix: surface tx hash after backend confirmation failures - #53

Open
antfleet-ops wants to merge 1 commit into
Virtual-Protocol:mainfrom
antfleet-ops:fix/acp-cli-surface-confirmation-tx
Open

fix: surface tx hash after backend confirmation failures#53
antfleet-ops wants to merge 1 commit into
Virtual-Protocol:mainfrom
antfleet-ops:fix/acp-cli-surface-confirmation-tx

Conversation

@antfleet-ops

Copy link
Copy Markdown

Summary

  • preserve the transaction hash when backend confirmation fails after an on-chain broadcast
  • include txnHash and action fields in JSON CLI errors for these recovery cases
  • keep successful compute top-up and client review output unchanged

Fixes #37.

Verification

  • npm run typecheck
  • npm run build

AntFleet audit provenance

Filed from antfleet-ops after AntFleet's two-model Virtuals repo scan found that compute top-up and client review could broadcast an on-chain transaction, then report only a backend confirmation failure without surfacing the transaction hash needed for reconciliation.

Constraint: preserve normal success output while making post-broadcast failures recoverable.\nRejected: surfacing only the backend error | hides the already-broadcast transaction hash.\nConfidence: high\nScope-risk: moderate\nDirective: after an on-chain broadcast, every downstream backend error must keep the tx hash visible.\nTested: npm run typecheck; npm run build\nNot-tested: live backend confirmation failure.
@antfleet-ops

Copy link
Copy Markdown
Author

Friendly ping — part of a small batch of independent acp-cli bug fixes (#50#53) from AntFleet's bench review; context and summary are in #50. MERGEABLE, no conflicts. Happy to adjust to fit your review flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant