Generate Struct RMW operations in the fuzzer#8535
Merged
Merged
Conversation
And allow fuzzing of initial contents that contain these operations.
kripken
approved these changes
Mar 27, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
lgtm % suggestion (also in the second function)
Comment on lines
+5603
to
+5605
| Type::isSubType( | ||
| type, | ||
| Type(HeapTypes::any.getBasic(type.getHeapType().getShared()), Nullable)); |
Member
There was a problem hiding this comment.
Suggested change
| Type::isSubType( | |
| type, | |
| Type(HeapTypes::any.getBasic(type.getHeapType().getShared()), Nullable)); | |
| type.getHeapType().getTop().isMaybeShared(HeapTypes::any) |
Member
Author
There was a problem hiding this comment.
That works here, but for cmpxchg below we're checking for a subtype of eq, so we can't just use getTop().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And allow fuzzing of initial contents that contain these operations.