PreserveImportsExportsJS fuzzer: Handle crashes and function ids#8648
Merged
Conversation
kripken
commented
Apr 27, 2026
kripken
commented
Member
- Report VM errors as failures (rather than see they still occur after opts).
- Ignore function ID differences in logging.
tlively
reviewed
Apr 27, 2026
Comment on lines
+2222
to
+2224
| # VM crashes are actual issues we want to find. | ||
| if '(core dumped)' in out or 'Received signal' in out or '== C stack trace ==' in out or '== JS stack trace ==' in out: | ||
| raise Exception(f"VM crash:\n\n{out}") |
Member
There was a problem hiding this comment.
Why is this different than in other fuzz handlers?
Member
Author
There was a problem hiding this comment.
Our normal JS is very careful to swallow and log any JS errors. The return code of the process is always 0.
Here we are running JS that is itself a fuzz testcase, and might error.
tlively
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.