Skip to content

Update length type from enum to string in summarization ability#347

Merged
dkotter merged 1 commit intoWordPress:developfrom
ocean90:fix/summarization-length-type
Mar 30, 2026
Merged

Update length type from enum to string in summarization ability#347
dkotter merged 1 commit intoWordPress:developfrom
ocean90:fix/summarization-length-type

Conversation

@ocean90
Copy link
Copy Markdown
Member

@ocean90 ocean90 commented Mar 29, 2026

What?

Corrects the type value for the summarization ability because enum is no type.

Why?

Ensures part of #346 is fixed.

How?

Replaces 'enum' with 'string'.

Use of AI Tools

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After
Open WordPress Playground Preview
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ocean90 <ocean90@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.85%. Comparing base (32c5e2d) to head (6f193ba).
⚠️ Report is 13 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #347   +/-   ##
==========================================
  Coverage      57.85%   57.85%           
  Complexity       615      615           
==========================================
  Files             46       46           
  Lines           3165     3165           
==========================================
  Hits            1831     1831           
  Misses          1334     1334           
Flag Coverage Δ
unit 57.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@dkotter dkotter added this to the 0.7.0 milestone Mar 30, 2026
@dkotter dkotter merged commit 73a1f87 into WordPress:develop Mar 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants