Skip to content

Use custom user agent for requests#85

Merged
ocean90 merged 3 commits intotrunkfrom
fix/set-user-agent-for-requests
Jul 6, 2020
Merged

Use custom user agent for requests#85
ocean90 merged 3 commits intotrunkfrom
fix/set-user-agent-for-requests

Conversation

@ocean90
Copy link
Copy Markdown
Member

@ocean90 ocean90 commented Jul 2, 2020

Related to https://wordpress.slack.com/archives/C02QB8GMM/p1593710560323900

On WordPress Trac UA rate-limiting is enabled. A custom UA would allow to whitelist requests by this task.
@whyisjake
Copy link
Copy Markdown
Member

whyisjake commented Jul 3, 2020

This patch is working for me.
@ocean90 ocean90 requested a review from aaronjorbin July 3, 2020 06:23
@ocean90 ocean90 merged commit 5b2f13d into trunk Jul 6, 2020
@ocean90 ocean90 deleted the fix/set-user-agent-for-requests branch July 6, 2020 07:02
@aaronjorbin
Copy link
Copy Markdown
Member

aaronjorbin commented Jul 6, 2020

The build is failing on this. @ntwb and @ocean90 , can y'all make it green again please
@ocean90
Copy link
Copy Markdown
Member Author

ocean90 commented Jul 6, 2020

@aaronjorbin Nope, it's totally unrelated.

[1] ERROR Module language-subtag-registry has an incompatible license 'ODC-By-1.0'.
[1] ERROR Module tslib has an incompatible license '0BSD'.
[1] npm ERR! code ELIFECYCLE
[1] npm ERR! errno 1
[1] npm ERR! grunt-patch-wordpress@2.0.0 check-licenses: wp-scripts check-licenses
@whyisjake
Copy link
Copy Markdown
Member

whyisjake commented Jul 6, 2020

The tests are fixed in #86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@ocean90 @whyisjake @aaronjorbin @ntwb