Added explanation of isEmpty function; extra line removed #61300
Added explanation of isEmpty function; extra line removed #61300Lovor01 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| Helper function to test if supplied variable (e.g. content of RichText) is empty. It tests if value of variable is empty or if variable is an empty array. | ||
|
|
||
| ### `value: String | Array` |
There was a problem hiding this comment.
Array is deprecated so I wouldn't document it here. Note that it can also be RichTextData
There was a problem hiding this comment.
Sorry, I had urgent matters and I forgot about this request - it seems to me that it could be RichTextValue, not RichTextData, but only in React native version. Deprecation notice on array is also only specified in React native version. Nevertheless, I agree with your comments.
|
|
||
| ## RichText.isEmpty | ||
|
|
||
| Helper function to test if supplied variable (e.g. content of RichText) is empty. It tests if value of variable is empty or if variable is an empty array. |
There was a problem hiding this comment.
Maybe the first line is explanatory enough?
|
Thank you for the PR! Looks good, just left some comments. |
Value explanation is removed and example is added.
I think it is fixed now according to suggestions. Sorry for being so late. |
isEmpty method of RichText object was not documented