ToggleControl: Add togglePosition prop for flexible switch placement#74658
Closed
shaunandrews wants to merge 1 commit intotrunkfrom
Closed
ToggleControl: Add togglePosition prop for flexible switch placement#74658shaunandrews wants to merge 1 commit intotrunkfrom
shaunandrews wants to merge 1 commit intotrunkfrom
Conversation
Adds a new `togglePosition` prop to ToggleControl that allows positioning the toggle switch at either the start (default) or end of the control, relative to the label. Uses logical positioning (start/end) for RTL support. - Add `togglePosition` prop with 'start' | 'end' values - Update styles with `.is-toggle-end` modifier - Add Storybook stories demonstrating the new prop - Add unit tests for toggle positioning - Expand documentation with design guidelines
|
Size Change: +101 B (0%) Total Size: 3.06 MB
ℹ️ View Unchanged
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Member
|
Given the patterns that we currently see, I'd say it's better to leave this to custom-composed implementations using the I also feel like we shouldn't be actively promoting this right-aligned pattern in this (and other similar controls like radio and checkbox), as it would encourage inconsistency. Unless we first create guidelines on when they're appropriate. |
Contributor
Author
|
Makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
togglePositionprop toToggleControlthat allows positioning the toggle switch at either the start (default) or end of the control, relative to the label.start/end) rather than physical (left/right) for proper RTL language support.is-toggle-endCSS modifier class for stylingTest Plan
togglePosition="end"places toggle after labelnpm run test-unit -- --testPathPattern=toggle-control