Skip to content

Implement proper Google provider using its first-class API#155

Merged
JasonTheAdams merged 11 commits intotrunkfrom
add/proper-google-provider-implementation
Dec 30, 2025
Merged

Implement proper Google provider using its first-class API#155
JasonTheAdams merged 11 commits intotrunkfrom
add/proper-google-provider-implementation

Conversation

@felixarntz
Copy link
Copy Markdown
Member

Fixes #106

Replaces #152 (which was accidentally using the protected feature/* branch prefix)

@felixarntz felixarntz added this to the 0.4.0 milestone Dec 30, 2025
@felixarntz felixarntz added the [Feature] New feature to highlight in changelogs. label Dec 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: JasonTheAdams <jason_the_adams@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz
Copy link
Copy Markdown
Member Author

@JasonTheAdams Can you please add #152 (comment) here?

@felixarntz
Copy link
Copy Markdown
Member Author

@JasonTheAdams 638a0ac addresses your feedback in #152 (comment). The same wording was already present in several other places, so I updated it everywhere.

@felixarntz
Copy link
Copy Markdown
Member Author

@JasonTheAdams Can you please give this a re-review so we can get it merged? No changes compared to #152, other than the extra commit above.

Copy link
Copy Markdown
Member

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM! 🚀

I did push my typing refactor, so let me know if you have any thoughts on that before we merge.

@JasonTheAdams JasonTheAdams merged commit d262f29 into trunk Dec 30, 2025
6 checks passed
@JasonTheAdams JasonTheAdams deleted the add/proper-google-provider-implementation branch December 30, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] New feature to highlight in changelogs.

2 participants