Rely on just-in-time translation loading#608
Merged
kasparsd merged 2 commits intoWordPress:masterfrom Apr 30, 2024
swissspidy:fix/load-textdomain
Merged
Rely on just-in-time translation loading#608kasparsd merged 2 commits intoWordPress:masterfrom swissspidy:fix/load-textdomain
kasparsd merged 2 commits intoWordPress:masterfrom
swissspidy:fix/load-textdomain
Conversation
6 tasks
kasparsd
approved these changes
Apr 30, 2024
Collaborator
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
This is great, thank you so much!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the manual
load_plugin_textdomain()call to rely on WordPress to load translations at the right time.Bumps the requirement to WordPress 4.6 accordingly.
Also, defines the
Requires *headers in the main plugin file so that WordPress can actually read them and prevent you from installing the plugin if requirements are not met.The headers mustn't really be set in the readme.
Why?
The plugin was loading translations too early on
plugins_loaded. Plugins should wait untilinitto ensure the current user has been set up, so that the current user's locale can be respected.That said, why manually load translations when WordPress can do it for you :-)
How?
Testing Instructions
Switch to a different language and see that the translations are still loaded as expected.
Screenshots or screencast
Changelog Entry