Merged
Conversation
- Adds PHP 8.4 - Updates builds to 8.3
kasparsd
approved these changes
Feb 13, 2025
Collaborator
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
This is great, thank you!
Collaborator
Looks like there is a known issue with missing 8.4 docker-library/wordpress#932 |
Contributor
Author
|
Closing this for now as the WordPress docker doesn't support 8.4 yet, so we'll have to wait or switch repos. |
Contributor
Author
|
I'll follow that issue and re-open once PHP 8.4 support is available. |
Contributor
Author
|
Re-opening as PHP 8.4 is now supported by the WordPress Docker image used by the tests. |
Contributor
Author
|
Yay! All tests passed! |
kasparsd
approved these changes
Mar 14, 2025
Collaborator
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
This is great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the tests to:
Why?
This should help ensure that the plugin works well with PHP 8.4 moving forward and ensure that the tests work better on a slightly updated PHP version 8.3.
How?
Manually edits the test file.
Changelog Entry
Changed - Update tests to include PHP 8.4