Skip to content

Added autocomplete attribute in the comment form #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thejaydip wants to merge 9 commits into from
Closed

Added autocomplete attribute in the comment form #2739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2cf7b83
Missing Doc comment added
thejaydip May 13, 2022
08cfdf1
PHPCS fixed - Missing Doc comment added
thejaydip May 13, 2022
76ccf08
Merge branch 'trunk' into trunk
SergeyBiryukov May 18, 2022
e89d9b4
Merge branch 'WordPress:trunk' into trunk
thejaydip May 23, 2022
b972f4b
Added autocomplete attribute in the comment form
thejaydip May 23, 2022
c651a12
Merge branch 'WordPress:trunk' into trunk
thejaydip May 26, 2022
7ec9c46
Fixed Twenty Twenty-Two: PHP notice error in the customizer
thejaydip May 26, 2022
e5420c3
Merge branch 'WordPress:trunk' into trunk
thejaydip Jun 2, 2022
b833bc3
Merge branch 'WordPress:trunk' into trunk
thejaydip Jun 6, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp-customize-nav-menus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ public function enqueue_scripts() {
'movedLeft' => __( 'Menu item moved out of submenu' ),
'movedRight' => __( 'Menu item is now a sub-item' ),
/* translators: ▸ is the unicode right-pointing triangle. %s: Section title in the Customizer. */
'customizingMenus' => sprintf( __( 'Customizing ▸ %s' ), esc_html( $this->manager->get_panel( 'nav_menus' )->title ) ),
'customizingMenus' => ( $this->manager->get_panel( 'nav_menus' ) ) ? sprintf( __( 'Customizing ▸ %s' ), esc_html( $this->manager->get_panel( 'nav_menus' )->title ) ) : __( 'Customizing' ),
/* translators: %s: Title of an invalid menu item. */
'invalidTitleTpl' => __( '%s (Invalid)' ),
/* translators: %s: Title of a menu item in draft status. */
Expand Down
6 changes: 3 additions & 3 deletions src/wp-includes/comment-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,7 @@ function comment_form( $args = array(), $post_id = null ) {
( $req ? $required_indicator : '' )
),
sprintf(
'<input id="author" name="author" type="text" value="%s" size="30" maxlength="245"%s />',
'<input id="author" name="author" type="text" value="%s" size="30" maxlength="245"%s autocomplete="name" />',
Copy link
Copy Markdown

@sabernhardt sabernhardt May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edit: This has an extra space before maxlength
Copy link
Copy Markdown

@bhrugesh96 bhrugesh96 May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
esc_attr( $commenter['comment_author'] ),
( $req ? $required_attribute : '' )
)
Expand All @@ -2384,7 +2384,7 @@ function comment_form( $args = array(), $post_id = null ) {
( $req ? $required_indicator : '' )
),
sprintf(
'<input id="email" name="email" %s value="%s" size="30" maxlength="100" aria-describedby="email-notes"%s />',
'<input id="email" name="email" %s value="%s" size="30" maxlength="100" aria-describedby="email-notes"%s autocomplete="email" />',
( $html5 ? 'type="email"' : 'type="text"' ),
esc_attr( $commenter['comment_author_email'] ),
( $req ? $required_attribute : '' )
Expand All @@ -2397,7 +2397,7 @@ function comment_form( $args = array(), $post_id = null ) {
__( 'Website' )
),
sprintf(
'<input id="url" name="url" %s value="%s" size="30" maxlength="200" />',
'<input id="url" name="url" %s value="%s" size="30" maxlength="200" autocomplete="url" />',
( $html5 ? 'type="url"' : 'type="text"' ),
esc_attr( $commenter['comment_author_url'] )
)
Expand Down