#59921 - Standardize Default Values in submit_button()#5687
#59921 - Standardize Default Values in submit_button()#5687andbalashov wants to merge 2 commits intoWordPress:trunkfrom
Conversation
In alignment with ticket #59921 and following the precedent set in changeset [31446], this commit updates the `submit_button()` function in the Administration component to standardize the default values of `$text` and `$other_attributes` parameters. Previously set to `null`, these defaults have now been changed to an empty string (`''`). This modification ensures consistency with the `get_submit_button()` function, which `submit_button()` wraps. The change maintains backward compatibility, as `get_submit_button()` does not perform strict type checking on these parameters. This update aligns with the ongoing effort to standardize function parameters across the WordPress codebase, improving readability and predictability of the core functions. References: - Ticket #59921 https://core.trac.wordpress.org/ticket/59921
|
Hi @andbalashov! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
…des/template.php/submit_button()
|
Thanks for the PR! Merged in r57128. |
2 participants
In alignment with ticket #59921 and following the precedent set in changeset [31446], this commit updates the
submit_button()function in the Administration component to standardize the default values of$textand$other_attributesparameters. Previously set tonull, these defaults have now been changed to an empty string (''). This modification ensures consistency with theget_submit_button()function, whichsubmit_button()wraps.The change maintains backward compatibility, as
get_submit_button()does not perform strict type-checking on these parameters. This update aligns with the ongoing effort to standardize function parameters across the WordPress codebase, improving the readability and predictability of the core functions.Trac ticket: https://core.trac.wordpress.org/ticket/59921
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.