Skip to content

Fix build on MacCatalyst - #37

Open
hossinasaadi wants to merge 6 commits into
ZeeZide:developfrom
hossinasaadi:develop
Open

Fix build on MacCatalyst#37
hossinasaadi wants to merge 6 commits into
ZeeZide:developfrom
hossinasaadi:develop

Conversation

@hossinasaadi

Copy link
Copy Markdown

fix build codeEditor for MacCatalyst
not find module 'CodeEditor' for target 'x86_64-apple-ios-macabi';

@SoylentGraham

Copy link
Copy Markdown

I have some similar changes in #36

... which I now see I never submitted a PR for :)

@hossinasaadi

Copy link
Copy Markdown
Author

I have some similar changes in #36

... which I now see I never submitted a PR for :)

Yeah, today i faced this issue and i felt like i should submit a PR for that too :)

@helje5

helje5 commented Mar 9, 2025

Copy link
Copy Markdown
Member

This seems to replace NSColor w/ Color, which looks incorrect? It should be UIColor on UIKit and stay as NSColor on AppKit.
A proper fix would likely have to adjust the #if os(macOS) guards to deal with Catalyst.

@SoylentGraham

Copy link
Copy Markdown

Why use UIColor, NSColor, and loads of macros... when you can use SwiftUi's Color in a SwiftUi API.

(Ps, dont use if(macos), use #if canimport(appkit) )

@hossinasaadi

Copy link
Copy Markdown
Author

@helje5 Now should works properly.

@hossinasaadi

Copy link
Copy Markdown
Author

Hi @helje5 , Is this not going to be merged? after while i use the Code Editor again and get same issue :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants