Skip to content

Provide detail info on untar failures.#2939

Merged
TingluoHuang merged 1 commit into
mainfrom
users/tihuang/detailuntar
Oct 19, 2023
Merged

Provide detail info on untar failures.#2939
TingluoHuang merged 1 commit into
mainfrom
users/tihuang/detailuntar

Conversation

@TingluoHuang

Copy link
Copy Markdown
Member

image

Take over #2923

@TingluoHuang TingluoHuang requested a review from a team as a code owner October 18, 2023 20:51

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hide whitespace when review for better diff.

if (exitCode != 0)
{
throw new InvalidActionArchiveException($"Can't use 'tar -xzf' extract archive file: {archiveFile}. Action being checked out: {downloadInfo.NameWithOwner}@{downloadInfo.Ref}. return code: {exitCode}.");
if (executionContext.Global.Variables.GetBoolean("DistributedTask.DetailUntarFailure") == true)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FF to make sure we rollout the change safely

@rentziass rentziass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit fb4bdbe into main Oct 19, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/detailuntar branch October 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants