Skip to content

Added Board WeAct Studio RP2350B Core#10646

Open
cvmanjoo wants to merge 7 commits intoadafruit:mainfrom
cvmanjoo:main
Open

Added Board WeAct Studio RP2350B Core#10646
cvmanjoo wants to merge 7 commits intoadafruit:mainfrom
cvmanjoo:main

Conversation

@bablokb
Copy link

bablokb commented Oct 14, 2025

I would suggest that you also add alias pin names for the ADCs:

{ MP_ROM_QSTR(MP_QSTR_GP40_A0), MP_ROM_PTR(&pin_GPIO40) },
{ MP_ROM_QSTR(MP_QSTR_GP40), MP_ROM_PTR(&pin_GPIO40) },
{ MP_ROM_QSTR(MP_QSTR_A0), MP_ROM_PTR(&pin_GPIO40) },

and so on for A0-A7. This would make writing portable code easier.

@cvmanjoo
Copy link
Author

Yes, I will add them, just trying to get PID for now.

@cvmanjoo cvmanjoo requested a review from dhalbert December 24, 2025 19:39
@dhalbert
Copy link
Collaborator

Check @bablokb's pin names suggestion above. Close to merging!

@cvmanjoo
Copy link
Author

@dhalbert Could you please check the above changes.

@embankment
Copy link

Good board! I hope this board definition will be in the next release.

@bablokb
Copy link

bablokb commented Feb 24, 2026

@cvmanjoo: according to the schematic, GPIO0 is used for PSRAM CS. You also have this pin in mpconfigboard.h for CIRCUITPY_PSRAM_CHIP_SELECT, this seems correct. Howver, since this pin is used internally, you should not expose it in pins.c (@dhalbert please correct me if I am wrong).

@IrregularShed
Copy link

Thank you for your work, @cvmanjoo - I was getting ready to try and do this all myself. Any chance of an update, @dhalbert (please) so we can have official support?

@dhalbert
Copy link
Collaborator

Howver, since this pin is used internally, you should not expose it in pins.c (@dhalbert please correct me if I am wrong).

That is correct: pins that are dedicated for internal uses, such as connecting to PSRAM or flash, should not be exposed in pins.c. Same of course for pins that are unconnected.

@dhalbert dhalbert dismissed their stale review February 24, 2026 16:12

resolved

@IrregularShed
Copy link

I've had a look around the hardware this afternoon, with the schematic and a multimeter. I've also built CircuitPython with the pin definitions from @cvmanjoo - my first time building it from scratch!

Unlike something less barebones - like the Feather RP2350, which tucks away GPIO8 purely for the PSRAM option - on this one GPIO0 gets broken out and can be used as a normal pin. They're also not (as far as I've been able to find) sold with a PSRAM chip fitted, so the default configuration is that GPIO0 is "just a pin" rather than something to reserve for internal use. For this to not be the case will be an exception, not the norm.

If it were up to me, I'd get rid of CIRCUITPY_PSRAM_CHIP_SELECT as standard, and add a caveat to the board documentation to say if you want to use PSRAM you'd need to build the firmware yourself, or offer a second board definition that includes the option. Personally, I think if you're up for soldering on an SMD memory chip on the underside of a cheap dev board, you should be able to do a DIY firmware build 😁

(As it is up to me for my own build, I've removed it from mine...)

@bablokb
Copy link

bablokb commented Feb 26, 2026

Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants