Skip to content

fix(overlay): remove nonexistent OverlayDialog export - #6790

Closed
kwy404 wants to merge 4 commits into
adobe:mainfrom
kwy404:kwy404/fix-overlay-dialog-export
Closed

kwy404 wants to merge 4 commits into
adobe:mainfrom
kwy404:kwy404/fix-overlay-dialog-export

Conversation

@kwy404

@kwy404 kwy404 commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Description

The exports map in @spectrum-web-components/overlay lists ./src/OverlayDialog.js, but there is no OverlayDialog source file in the package, so that path can never resolve. This removes the stale entry.

Motivation and context

Tooling that reads the exports map, and consumers browsing it, are pointed at a module that does not exist.

Related issue(s)

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Exports map only lists existing files
    1. Run yarn build in 1st-gen
    2. Check that every path in the exports field of 1st-gen/packages/overlay/package.json exists in the package
    3. Expect no OverlayDialog entry and no missing files

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Not applicable: this only changes the package exports map and has no runtime or UI effect.

@kwy404
kwy404 requested a review from a team as a code owner September 23, 2026 23:35
@changeset-bot

changeset-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 299559b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc added the Contribution PRs from contributors label Sep 24, 2026
@rubencarvalho rubencarvalho added bug Something isn't working Status:Ready for review PR ready for review or re-review. gen1 labels Sep 24, 2026
@rubencarvalho rubencarvalho self-assigned this Sep 24, 2026
@Rajdeepc Rajdeepc self-assigned this Sep 24, 2026
@coveralls

coveralls commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35983490584

Warning

No base build found for commit f9d5366 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.291%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 39853
Covered Lines: 38574
Line Coverage: 96.79%
Relevant Branches: 6572
Covered Branches: 6129
Branch Coverage: 93.26%
Branches in Coverage %: Yes
Coverage Strength: 461.95 hits per line

💛 - Coveralls
@rubencarvalho

Copy link
Copy Markdown
Contributor

Thank you so much for this fix, @kwy404! 🙏
Our CI can't use repository secrets on PRs from forks yet, so some required checks can't run here. To get this merged, we moved your change to an internal PR: #6794. Your commit is carried over unchanged, and you're still its author, so you keep full credit.

We'll close this PR in favor of #6794 . Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Contribution PRs from contributors gen1 Status:Ready for review PR ready for review or re-review.

4 participants