You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The exports map in @spectrum-web-components/overlay lists ./src/OverlayDialog.js, but there is no OverlayDialog source file in the package, so that path can never resolve. This removes the stale entry.
Motivation and context
Tooling that reads the exports map, and consumers browsing it, are pointed at a module that does not exist.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No base build found for commit f9d5366 on main.
Coverage changes can't be calculated without a base build. If a base build is processing, this comment will update automatically when it completes.
Coverage: 96.291%
Details
Patch coverage: No coverable lines changed in this PR.
Thank you so much for this fix, @kwy404! 🙏
Our CI can't use repository secrets on PRs from forks yet, so some required checks can't run here. To get this merged, we moved your change to an internal PR: #6794. Your commit is carried over unchanged, and you're still its author, so you keep full credit.
We'll close this PR in favor of #6794 . Thanks again for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
exportsmap in@spectrum-web-components/overlaylists./src/OverlayDialog.js, but there is noOverlayDialogsource file in the package, so that path can never resolve. This removes the stale entry.Motivation and context
Tooling that reads the exports map, and consumers browsing it, are pointed at a module that does not exist.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
yarn buildin1st-genexportsfield of1st-gen/packages/overlay/package.jsonexists in the packageOverlayDialogentry and no missing filesDevice review
Accessibility testing checklist
Not applicable: this only changes the package
exportsmap and has no runtime or UI effect.