Summary
The parameterless MessagePackInputFormatter() constructor uses default serializer options, which resolve to MessagePackSerializerOptions.Standard with MessagePackSecurity.TrustedData. The formatter is designed for ASP.NET Core MVC request bodies, which commonly cross an HTTP trust boundary.
This insecure default can expose applications to denial-of-service attacks that MessagePackSecurity.UntrustedData is intended to mitigate, such as hash-collision attacks against dictionary-like model properties.
Impact
Applications are affected when they register new MessagePackInputFormatter() without explicitly passing serializer options configured for untrusted data.
An unauthenticated or otherwise untrusted HTTP client can send MessagePack request bodies that are deserialized using the trusted-data posture. For models containing hash-based collections, this can enable algorithmic complexity attacks using colliding keys. The default constructor makes the unsafe posture easy to use at the exact boundary where request bodies should be treated as untrusted.
Affected components
- Package:
MessagePack.AspNetCoreMvcFormatter
- API:
MessagePackInputFormatter() parameterless constructor
- Scenario: ASP.NET Core MVC model binding from HTTP request bodies
- Finding IDs:
MESSAGEPACKCSHARP-OPEN-009, duplicate MESSAGEPACKCSHARP-095
Patches
Fixes are prepared and will be released in coordinated patch versions.
Upgrade guidance:
- Upgrade
MessagePack.AspNetCoreMvcFormatter to the patched version for your release line.
- Upgrade companion MessagePack packages in the same dependency graph to the coordinated patched versions.
The fix should default the parameterless constructor to MessagePackSerializerOptions.Standard.WithSecurity(MessagePackSecurity.UntrustedData), or require callers to pass explicit options so the trust posture is deliberate.
Workarounds
Do not use the parameterless constructor on affected versions. Register the formatter with explicit untrusted-data options, for example:
options.InputFormatters.Add(
new MessagePackInputFormatter(
MessagePackSerializerOptions.Standard.WithSecurity(MessagePackSecurity.UntrustedData)));
Also apply normal HTTP request-size limits and model validation appropriate for your service.
Resources
MESSAGEPACKCSHARP-OPEN-009: MVC input formatter defaults to trusted-data security posture
MESSAGEPACKCSHARP-095: duplicate finding for the same root cause
- CWE-1188: Initialization of a Resource with an Insecure Default
References
Summary
The parameterless
MessagePackInputFormatter()constructor uses default serializer options, which resolve toMessagePackSerializerOptions.StandardwithMessagePackSecurity.TrustedData. The formatter is designed for ASP.NET Core MVC request bodies, which commonly cross an HTTP trust boundary.This insecure default can expose applications to denial-of-service attacks that
MessagePackSecurity.UntrustedDatais intended to mitigate, such as hash-collision attacks against dictionary-like model properties.Impact
Applications are affected when they register
new MessagePackInputFormatter()without explicitly passing serializer options configured for untrusted data.An unauthenticated or otherwise untrusted HTTP client can send MessagePack request bodies that are deserialized using the trusted-data posture. For models containing hash-based collections, this can enable algorithmic complexity attacks using colliding keys. The default constructor makes the unsafe posture easy to use at the exact boundary where request bodies should be treated as untrusted.
Affected components
MessagePack.AspNetCoreMvcFormatterMessagePackInputFormatter()parameterless constructorMESSAGEPACKCSHARP-OPEN-009, duplicateMESSAGEPACKCSHARP-095Patches
Fixes are prepared and will be released in coordinated patch versions.
Upgrade guidance:
MessagePack.AspNetCoreMvcFormatterto the patched version for your release line.The fix should default the parameterless constructor to
MessagePackSerializerOptions.Standard.WithSecurity(MessagePackSecurity.UntrustedData), or require callers to pass explicit options so the trust posture is deliberate.Workarounds
Do not use the parameterless constructor on affected versions. Register the formatter with explicit untrusted-data options, for example:
Also apply normal HTTP request-size limits and model validation appropriate for your service.
Resources
MESSAGEPACKCSHARP-OPEN-009: MVC input formatter defaults to trusted-data security postureMESSAGEPACKCSHARP-095: duplicate finding for the same root causeReferences