Conversation
`maxConcurrent` was hardcoded to 1, so throughput was `1 / max(minTime, latency)` rather than the configured rate. With a 60/minute limit and 2s responses that is 30 requests/minute -- half the allowance, and no setting could recover it. Concurrency is independent of the rate limit here: `minTime` still spaces request *starts*, so raising this cannot exceed the configured requests-per-interval. It only stops latency from dragging throughput below the target. Defaults to 1, so existing behaviour is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pyrogenic
marked this pull request as ready for review
August 23, 2026 02:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createLimiterhardcodesmaxConcurrent: 1, which serializes requests. If requests average > 1s, you won't actually reach the number of requests per minute allowed (60). This change lets callers have multiple requests in-flight.I have a large collection (11 pages of collection, then inventory, lists, etc.). Refreshing it with serial requests stayed far under 60 requests/min, and with
maxConcurrent: 5I could reach my configured ceiling (48) without any 429s.