fix: implement custom nullability for spark abs function - #19395
Merged
Merged
Conversation
Fixes apache#19162 The SparkAbs UDF was using the default is_nullable=true for all outputs, even when inputs were non-nullable. This commit implements return_field_from_args to properly propagate nullability from input arguments. Changes: - Add return_field_from_args implementation to SparkAbs - Output nullability now matches input nullability - Handle edge case where scalar argument is explicitly null - Add tests for nullability behavior
Contributor
Author
martin-g
reviewed
Dec 19, 2025
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
Contributor
Author
|
thanks @martin-g |
Jefffrey
reviewed
Dec 24, 2025
Jefffrey
approved these changes
Dec 25, 2025
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache/datafusion #19162
The SparkAbs UDF was using the default is_nullable=true for all outputs, even when inputs were non-nullable. This commit implements return_field_from_args to properly propagate nullability from input arguments.
Changes:
Which issue does this PR close?
Closes #19162
Rationale for this change
SparkAbs was always returning
nullable=trueeven for non-nullable inputs.What changes are included in this PR?
Implement return_field_from_args to propagate nullability from input arguments.
Are these changes tested?
Yes, added 2 tests for nullability behavior.
Are there any user-facing changes?
No.