Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Get rid of monkey patching in LossScaler overflow handling (#18959) - #18973

Merged
ptrendx merged 1 commit into
apache:v1.xfrom
mk-61:pr-no-monkeys-v1-cherrypick
Aug 24, 2020
Merged

Get rid of monkey patching in LossScaler overflow handling (#18959)#18973
ptrendx merged 1 commit into
apache:v1.xfrom
mk-61:pr-no-monkeys-v1-cherrypick

Conversation

@mk-61

@mk-61 mk-61 commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

Co-authored-by: Vladimir Cherepanov vcherepanov@nvidia.com

Description

Cherry-pick from master

)

Co-authored-by: Vladimir Cherepanov <vcherepanov@nvidia.com>
@mxnet-bot

Copy link
Copy Markdown

Hey @mk-61 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, windows-gpu, edge, centos-cpu, miscellaneous, unix-cpu, website, windows-cpu, centos-gpu, clang, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ptrendx ptrendx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mk-61

mk-61 commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [website]

@mxnet-bot

Copy link
Copy Markdown

Jenkins CI successfully triggered : [website]

@mk-61

mk-61 commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot

Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu, unix-gpu]

@ptrendx
ptrendx merged commit dfefe87 into apache:v1.x Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants