Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX: add faster_rcnn_fpn models - #20190

Merged
Zha0q1 merged 1 commit into
apache:v1.xfrom
Zha0q1:onnx_fix_fast_rcnn
Apr 20, 2021
Merged

[v1.x] ONNX: add faster_rcnn_fpn models#20190
Zha0q1 merged 1 commit into
apache:v1.xfrom
Zha0q1:onnx_fix_fast_rcnn

Conversation

@Zha0q1

@Zha0q1 Zha0q1 commented Apr 19, 2021

Copy link
Copy Markdown
Contributor

#20178 fixes 2 faster_rcnn_fpn models too, adding them to model tests

@mxnet-bot

Copy link
Copy Markdown

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, centos-cpu, unix-cpu, windows-cpu, miscellaneous, sanity, windows-gpu, edge, unix-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

onnx_class_ids, onnx_scores, onnx_boxes = session.run([], {input_name: img_data.asnumpy()})
assert_obj_detetion_result(mx_class_ids[0], mx_scores[0], mx_boxes[0],
onnx_class_ids[0], onnx_scores[0], onnx_boxes[0],
score_thresh=0.8, score_tol=0.05, box_tol=30)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other object detection models are able to pass the test with box_tol=0.01, but here we loose it to box_tol=30 for faster_rcnn models. Do we know what causes the accuracy regression here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the onnx model can predict the same objects with very similar scores. It's just with a few boxes one of the four values (xstart, xend, ystart, yend) can differ by quit a bit (refer to the bbox of the boy in red). I am not sure about the cause, but it must be related to the fpn structure.

soccer_onnx)

soccer_mx

@waytrue17 waytrue17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Zha0q1
Zha0q1 merged commit b0807c3 into apache:v1.x Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants