NIFI-15961 - Add Kafka share-group support to ConsumeKafka - #11271
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-15961 - Add Kafka share-group support to ConsumeKafka#11271pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
Introduce share-group consumption for ConsumeKafka backed by Kafka 4.2's GA share consumer (KIP-932). A new "Group Type" property selects between the existing classic Consumer Group code path (default; preserves all prior behavior) and the new Share Group path, and a new "Acknowledgement Mode" property gates per-record vs. implicit acknowledgement when the share-group path is selected. - New KafkaShareConsumerService API contract plus Kafka4ShareConsumerService implementation wrapping org.apache.kafka.clients.consumer.ShareConsumer. - KafkaConnectionService gains a default getShareConsumerService() so third-party connection services remain ABI-compatible and only opt in when they support share groups. - Kafka3ConnectionService strips the classic-consumer properties rejected by ShareConsumerConfig.SHARE_GROUP_UNSUPPORTED_CONFIGS before constructing the share consumer. - ConsumeKafka.verify() exercises a share-group subscription and releases any sampled records back to the share group. - Bump the integration-test broker to apache/kafka:4.2.0 (the version that matches the bundled kafka-clients and the first release where share groups are GA). - Add unit tests for the share-consumer service (poll, explicit/implicit ack, commit, rollback, close, tombstone handling), the processor's share-group selection/verification/ack-mode wiring, and an integration test ConsumeKafkaShareGroupIT. Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>
Contributor
Author
|
I rebased on latest and I'll add Kafka Share-Group backlog reporting as a follow-up item. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15961 - Add Kafka share-group support to ConsumeKafka
Introduce share-group consumption for ConsumeKafka backed by Kafka 4.2's GA share consumer (KIP-932). A new "Group Type" property selects between the existing classic Consumer Group code path (default; preserves all prior behavior) and the new Share Group path, and a new "Acknowledgement Mode" property gates per-record vs. implicit acknowledgement when the share-group path is selected.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation