Skip to content

NIFI-4870 Upgraded activemq-client and activemq-broker versions to 5.… - #2469

Closed
alopresto wants to merge 2 commits into
apache:masterfrom
alopresto:NIFI-4870
Closed

NIFI-4870 Upgraded activemq-client and activemq-broker versions to 5.…#2469
alopresto wants to merge 2 commits into
apache:masterfrom
alopresto:NIFI-4870

Conversation

@alopresto

Copy link
Copy Markdown
Contributor

…15.3.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mosermw

mosermw commented Feb 14, 2018

Copy link
Copy Markdown
Member

Hi @alopresto, should we update the copyright year to 2018 in the applicable NOTICE files?

@alopresto

Copy link
Copy Markdown
Contributor Author

Updated copyright years to 2017 (as referenced in activemq NOTICE).

@mcgilman

mcgilman commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

Will review...

@mcgilman

mcgilman commented Mar 9, 2018

Copy link
Copy Markdown
Contributor

Thanks @alopresto! This has been merged to master.

@asfgit asfgit closed this in e9d585a Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants