Skip to content

Some ASCII-safe constants as byte[] to obviate ASCII-check - #249

Open
DanskerDave wants to merge 1 commit into
apache:masterfrom
DanskerDave:master
Open

Some ASCII-safe constants as byte[] to obviate ASCII-check#249
DanskerDave wants to merge 1 commit into
apache:masterfrom
DanskerDave:master

Conversation

@DanskerDave

Copy link
Copy Markdown

No description provided.

@codecov-commenter

codecov-commenter commented Nov 18, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.54%. Comparing base (0d5a278) to head (9607142).
⚠️ Report is 1011 commits behind head on master.

Files with missing lines Patch % Lines
...ava/org/apache/axiom/mime/MultipartBodyWriter.java 85.18% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   58.52%   58.54%   +0.02%     
==========================================
  Files         515      515              
  Lines       14794    14807      +13     
  Branches     2553     2555       +2     
==========================================
+ Hits         8658     8669      +11     
- Misses       5539     5540       +1     
- Partials      597      598       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@veithen

veithen commented Nov 20, 2022

Copy link
Copy Markdown
Member

Is this change motivated by profiling, i.e. does it address an actual performance issue?

@DanskerDave

Copy link
Copy Markdown
Author

Is this change motivated by profiling, i.e. does it address an actual performance issue?

Well, it will make it a tad faster, by not checking that Strings known to be pure ASCII, really are ASCII.

Having them compiled as byte[] will save a bit too.

My Climate-Change contribution to save the planet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants