Skip to content

Report Basic-auth registry failures as credential errors#768

Open
kiwigitops wants to merge 1 commit into
apple:mainfrom
kiwigitops:codex/basic-auth-registry-error
Open

Report Basic-auth registry failures as credential errors#768
kiwigitops wants to merge 1 commit into
apple:mainfrom
kiwigitops:codex/basic-auth-registry-error

Conversation

@kiwigitops

Copy link
Copy Markdown

Addresses apple/container#1538.

Summary:

  • preserves the existing Bearer-token path when a registry advertises Bearer auth
  • reports Basic-auth 401/403 responses with supplied credentials as access denied or wrong credentials
  • adds focused coverage for Basic-only WWW-Authenticate challenges with and without credentials

Verification:

  • git diff --check
@kiwigitops

Copy link
Copy Markdown
Author

Quick bump. Happy to adjust the error wording or tests if this should line up with a different registry auth path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants