Use weights_only=True when loading sensitivities (#16)#18
Open
BiswajeetRay7 wants to merge 2 commits into
Open
Use weights_only=True when loading sensitivities (#16)#18BiswajeetRay7 wants to merge 2 commits into
BiswajeetRay7 wants to merge 2 commits into
Conversation
BiswajeetRay7
force-pushed
the
fix-sensitivities-weights-only
branch
2 times, most recently
from
fbc7aa1 to
33dc383
Compare
Signed-off-by: Biswajeet Ray <raybiswajeet2@gmail.com>
BiswajeetRay7
force-pushed
the
fix-sensitivities-weights-only
branch
from
33dc383 to
3520a77
Compare
aseemw
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16
KMeansPalettizer.prepareloadedsensitivity_pathviatorch.loadwithoutweights_only=True, unlike the checkpoint load path which already uses it. Sincetorch.loaddefaults to pickle, an untrusted/shared sensitivity file could execute arbitrary code on load (CWE-502). Sensitivities are onlydict[str, torch.Tensor], soweights_only=Trueis fully backward compatible.