Avoid mutating input shapes when creating EnumeratedShapes - #2873
Open
dipeshbabu wants to merge 2 commits into
Open
dipeshbabu wants to merge 2 commits into
dipeshbabu wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumeratedShapesaliases the first input shape's dimension list and replaces entries while computing its common symbolic shape. ConstructingEnumeratedShapes([shape, (1, 4)])withshape = Shape((1, 2))therefore turns the caller's fixed shape into a symbolic one. Reusing that shape in another enumeration also changes the first enumeration, andTensorTypecan stop rejecting incompatible optional defaults.Copy the dimension list before combining shapes. A shallow copy preserves symbol identity and takes space proportional to tensor rank; tensor data and input
Shapeobjects are not copied.Validation:
coremltools.converters.mil.mil.tests, which the configured GitLab MIL job discovers.git diff --checkpassed.Local test command (pytest file logging/cache disabled because sandbox writes were denied):