fix: Allow aggregates to reference other aggregates #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed verifier from EnsureAggregateFieldIsAttributeOrCalculation to ValidateAggregateField and added aggregates to the list of valid field types.
Fixed case clause ordering in `Ash.Query.Aggregate.new/4` so that
`%Ash.Resource.Aggregate{}` matches before the generic pattern.
Also updated `aggregate_type/2` to recursively resolve nested aggregate types.
Updated `Ash.Resource.Info`, `Ash.Sort`, and `Ash.Domain.Info.Diagram` modules to delegate to `Ash.Query.Aggregate.aggregate_type/2` instead of duplicating the logic.
This stops test failures from concurrently-running tests intermittently making this test fail
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #2519, allows aggregates to reference other aggregates (with type resolution).
EnsureAggregateFieldIsAttributeOrCalculationverifier to justValidateAggregateField(becauseEnsureAggregateFieldIsAttributeOrCalculationOrAggregateis a bit verbose) to allow aggregatesAsh.Query.Aggregate.newto check aggregate types both first and recursively, ahead of the generic caseAsh.Domain.Info.DiagramThe tests look a bit odd because there's assertions inside a
capture_ioblock but as I found out, defining a module inside acapture_ioblock in order to capture any generated warnings, doesn't make the module accessible outside the block 🫠Contributor checklist
Leave anything that you believe does not apply unchecked.